Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop deploying to the release- folder #706

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Conversation

fredrikekre
Copy link
Member

This should actually be safe since Documenter don't remove the old directories, so links should still work.

@mortenpi
Copy link
Member

Code LGTM. I would leave this open for a short while to see if we gather any feedback.

You're right that this is essentially non-breaking. But I think I should nevertheless ANN the release with this change on Discourse, possibly together with a script / automated PRs that would remove the old release-x.y directories from packages.

@mortenpi
Copy link
Member

Also, I was wondering that perhaps we should move the release-x.y ones last in generate_version_file in this PR? I.e. in for group in (named_folders, release_folders, tag_folders). Or, I guess we could remove them altogether.. this way they will stay on the gh-pages branch, but will be hidden from the reader.

@fredrikekre
Copy link
Member Author

Yea lets move them last. If people don't want them to show they can purge the gh-pages branch from these. Then some time in the future we can remove them from generate_version_file, since at that time Documenter has not build those branches in a while anywa.

@fredrikekre fredrikekre force-pushed the fe/rm-release-folder branch 3 times, most recently from 66b601d to 519f969 Compare April 16, 2018 11:18
@fredrikekre fredrikekre force-pushed the fe/rm-release-folder branch from 519f969 to f7aae0f Compare April 17, 2018 11:18
@fredrikekre
Copy link
Member Author

Actually, lets remove them from the version selector but leave the old release- folders on the branch. That way links will still work as you say.

@fredrikekre fredrikekre force-pushed the fe/rm-release-folder branch from 7163891 to 0bcb901 Compare April 17, 2018 20:23
@mortenpi mortenpi mentioned this pull request Apr 21, 2018
11 tasks
@mortenpi mortenpi added this to the BREAKING milestone Apr 21, 2018
@fredrikekre fredrikekre force-pushed the fe/rm-release-folder branch 2 times, most recently from 048c6d3 to bfc268b Compare April 24, 2018 07:21
@fredrikekre fredrikekre force-pushed the fe/rm-release-folder branch from bfc268b to 0e76d05 Compare August 16, 2018 06:02
@fredrikekre
Copy link
Member Author

Rebased.

@fredrikekre fredrikekre merged commit b598cb0 into master Aug 16, 2018
@fredrikekre fredrikekre deleted the fe/rm-release-folder branch August 16, 2018 07:46
@mortenpi mortenpi modified the milestones: BREAKING, 0.20.0 Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants