Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch over to LibGit2 #686

Closed
mortenpi opened this issue Mar 23, 2018 · 2 comments
Closed

Switch over to LibGit2 #686

mortenpi opened this issue Mar 23, 2018 · 2 comments
Labels
Status: Available Type: Enhancement Type: Maintenance

Comments

@mortenpi
Copy link
Member

mortenpi commented Mar 23, 2018 •
edited
Loading

Since LibGit2 is available in core Julia, we should probably use it in deploydocs etc., and not depend on the git binary. Should make using Documenter on Windows a bit easier and also relevant for container-based builds (e.g. on GitLab, #661).
@mortenpi mortenpi added this to the 1.0 milestone Mar 23, 2018
@mortenpi mortenpi mentioned this issue Jul 11, 2018
Closed
@tpapp
Copy link
Contributor

tpapp commented Dec 29, 2018

It seems that even makedocs uses git, eg with a repo spec like

    repo = "https://gitlab.com/tkpapp/GitlabJuliaDemo.jl/blob/{commit}{path}#{line}"

@mortenpi mortenpi mentioned this issue Jun 12, 2020
Merged
@mortenpi mortenpi removed this from the (n+1).0 milestone Oct 30, 2022
@mortenpi
Copy link
Member Author

Superseded by #2348. LibGit2 is basically deprecated, so we don't want to build on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Available Type: Enhancement Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpapp @mortenpi