Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes search window does not appear #2458

Merged
merged 19 commits into from
Feb 21, 2024
Merged

Conversation

Hetarth02
Copy link
Contributor

This PR aims to fix Issue #2430.

@goerz
Copy link
Member

goerz commented Feb 20, 2024

This kind of PR would really benefit from having a preview build of the documentation. That's only possible for PRs where the branch is directly in the main repository, though, right?

@mortenpi Is there some other way to allow preview builds when the PR comes from someone without write permissions to the repository? Maybe by applying some tag/label to the PR?

@mortenpi
Copy link
Member

@mortenpi Is there some other way to allow preview builds when the PR comes from someone without write permissions to the repository? Maybe by applying some tag/label to the PR?

It's not obvious how to do this. PRs don't have access to secrets. Maybe we could have the workflow upload an artifact, and then a label to pull and unpack that to gh-pages on-demand (by a maintainer).

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The original issue isn't very easy to repro, but I think this should fix it.

@mortenpi mortenpi enabled auto-merge (squash) February 21, 2024 02:56
@mortenpi mortenpi merged commit dc4b33c into JuliaDocs:master Feb 21, 2024
18 of 21 checks passed
@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Bugfix labels Feb 21, 2024
@Hetarth02 Hetarth02 deleted the Issue-2430 branch February 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants