Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Search filter toggle buttons UI #2408

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Fix Search filter toggle buttons UI #2408

merged 3 commits into from
Jan 22, 2024

Conversation

Hetarth02
Copy link
Contributor

This PR aims to fix Issue #2406.

Filter Not selected:
image

Filter selected:
image

@Hetarth02
- Removed repeated result badge class from documenter-dark scss
c33c559 
- Removed extra whitespace documenter-dark scss file
- Updated CHANGELOG.md
LilithHafner
LilithHafner reviewed Jan 21, 2024
View reviewed changes
Copy link
Contributor

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it difficult to review the change to assets/html/themes/documenter-dark.css. Would you clarify what that change is? (It seems to me that maybe that file should not be under source control at all, but that may be off topic for this PR)

@Hetarth02
Copy link
Contributor Author

assets/html/scss/documenter-dark.scss this is the file with changes.

.css files are compiled versions of the .scss files.

mortenpi
mortenpi approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mortenpi mortenpi enabled auto-merge (squash) January 22, 2024 01:08
@mortenpi mortenpi linked an issue Jan 22, 2024 that may be closed by this pull request
Search filter toggle buttons have broken UI [regression] #2406
Closed
@mortenpi mortenpi merged commit 516cb5f into JuliaDocs:master Jan 22, 2024
18 of 21 checks passed
@Hetarth02 Hetarth02 deleted the Issue-2406 branch January 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilithHafner LilithHafner LilithHafner left review comments

@mortenpi mortenpi mortenpi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search filter toggle buttons have broken UI [regression]
3 participants
@Hetarth02 @mortenpi @LilithHafner