-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made search case insensitive #2374
Conversation
- Updated the UI for the actual search results
@mortenpi Before merging, where do I add the entry in |
Vim has |
Above 1.2.1 in a new header with |
Why not a togglable setting for case-sensitivity? Seems more intuitive. |
Honestly, this seems like an upstream bug in mini-search. I would hope that even a very light fuzzy search would fix this, but apparently they use Levenshtein edit distance to compute fuzzy matches which is not a case-aware system (i.e. Editlink and editlink are equally far apart as editWink and editlink). I think smartcase seems like a reasonable idea and it's also worth trying out |
- Updated CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an unambiguous improvement. LGTM.
Smartcase is certainly an interesting idea to try out, but does not block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, sorry for the delay. Thank you!
This PR aims to fix Issue #2373.