Add support for Woodpecker CI 1.x and 2.x #2339
Conversation
Everyone is advised to use >= 1.0.0 Woodpecker versions Signed-off-by: Soc Virnyl Estela <[email protected]>
uncomfyhalomacro
force-pushed
the
backward-compatibility-for-supporting-woodpecker-ci-versions
branch
from
250d8df to
fe856d1
Compare
Signed-off-by: Soc Virnyl Estela <[email protected]>
Signed-off-by: Soc Virnyl Estela <[email protected]>
Signed-off-by: Soc Virnyl Estela <[email protected]>
This reverts commit ffa5338.
Signed-off-by: Soc Virnyl Estela <[email protected]>
Signed-off-by: Soc Virnyl Estela <[email protected]>
Signed-off-by: Soc Virnyl Estela <[email protected]>
Signed-off-by: Soc Virnyl Estela <[email protected]>
|
Ready for review. Not sure pinging is the correct way to ask for code review. Sorry! |
…pecker-ci-versions
…pecker-ci-versions
…to backward-compatibility-for-supporting-woodpecker-ci-versions This merge updates the branch from upstream changes. Original code hasnt changed Signed-off-by: Soc Virnyl Estela <[email protected]>
Signed-off-by: Soc Virnyl Estela <[email protected]>
There was a problem hiding this comment.
Apologies for the delay here. I haven't really tested this, but the changes LGTM, and the test suite looks really comprehensive. Thank you!
It's ready to be merged, right? Would you mind adding a note into CHANGELOG.md?
Also, something to maybe be aware of: we'll change to Git.jl for git (#2348). I assume it should just work on Woodpecker, but you never know.
Signed-off-by: Soc Virnyl Estela <[email protected]>
It should probably just work assuming EDIT: Looking at Git.jl, I guess it's 1:1 since it uses a |
|
It seems I forgot that 2.0.0 was released recently. That was fast. I guess I will update the docs and the links which causes linkchecks to fail. |
Signed-off-by: Soc Virnyl Estela <[email protected]>
|
\cc @mortenpi ready for merging. thank you! |
…pecker-ci-versions
mortenpi
changed the title
|
Thanks for iterating on this @uncomfyhalomacro! |
Breaking Change
This PR supersedes #2335. The changes introduced are the following
Removed environmental variables required in the struct
WoodpeckerFORGE_URL. This is not needed based on my usage.woodpecker_repo_linkwhich usesCI_REPO_LINK. The environmental variableCI_REPO_LINKis still used if the version is 0.15.0. We just manually change it getwoodpecker_forge_urlto allow compatibility between woodpecker versions.Reason for removing
woodpecker_repo_linkis thatCI_REPOalready contains<owner>/<name>.Changed or renamed environmental variables
CI_BUILD_EVENT->CI_PIPELINE_EVENT. 0.15.x used to use theCI_BUILD_EVENT. Latest release will useCI_PIPELINE_EVENT. Woodpecker 2.0.0 will removeCI_BUILD*environmental variables entirely and replace it withCI_PIPELINE*. So we are preparing for that transition.New environmental variables to be used
CI_FORGE_URL. This is the URL for the constructed forge e.g.https://github.aaakk.us.kgorhttps://gitlab.com. To allow compatibility prior 1.0.0,CI_REPO_LINKis used withmatch.CI_SYSTEM_VERSION. Returns the version number of currently used Woodpecker CI system. This is the environmental variable to be used to check versions.