Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements for remotes keyword #2242

Open
4 tasks
mortenpi opened this issue Sep 5, 2023 · 3 comments
Open
4 tasks

Documentation improvements for remotes keyword #2242

mortenpi opened this issue Sep 5, 2023 · 3 comments

Comments

@mortenpi
Copy link
Member

mortenpi commented Sep 5, 2023

  • The makedocs docstring should make it clear that it needs to be a Dict (not a Vector{Pair}).
  • The commit value must be a string and should be any Git ref (doesn't have to be a commit, can also be a version tag).
  • We should add a helpful error message if the user passes a VersionNumber as commit (saying to convert to string first).
  • We should add docs examples for both Pkg.develop case (can determine commit automatically), and Pkg.add case (user needs to supply the version tag).

cc @baggepinnen

@odow
Copy link
Collaborator

odow commented Sep 24, 2023

We should add docs examples for both Pkg.develop case (can determine commit automatically), and Pkg.add case (user needs to supply the version tag).

How does one do this? jump-dev/JuMP.jl#3526

@mortenpi
Copy link
Member Author

You pass a tuple instead, i.e. path::String => (remote::Remote, commit::String).

remote = if remoteref isa Tuple{Remotes.Remote, AbstractString}
RemoteRepository(path, remoteref[1], remoteref[2])

@odow
Copy link
Collaborator

odow commented Sep 24, 2023

You pass a tuple instead

Aaaaaah. I missed this part. I was looking in the Remotes module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants