Remove search.js as separate overridable asset #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
added
Type: Maintenance
Type: Breaking
Format: HTML
|
@mortenpi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now load
search.jsanyway on every HTML page, we can just combine it intodocumenter.js, so simplify our assets handling. cc @Hetarth02 -- can you think of any reason we shouldn't do this?This is technically breaking, since previously you could actually provide a custom
search.jsfile that overrides Documenter's implementation. But I assume it is not used very much.. and anyway those files would be broken by the new UI.