Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size_threshold_ignore to HTML, to ignore specific pages #2211

Closed
mortenpi opened this issue Aug 17, 2023 · 1 comment · Fixed by #2252
Closed

Add size_threshold_ignore to HTML, to ignore specific pages #2211

mortenpi opened this issue Aug 17, 2023 · 1 comment · Fixed by #2252
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Milestone

Comments

@mortenpi
Copy link
Member

Suggested by @odow in #2205 (comment), to have a bit more fine grained way to ignore some pages going over the size threshold.

Behavior-wise, I would suggest that the ignored pages still warn if they go over the size_threshold_warn limit, as this is supposed to be a temporary solution. So effectively it sets size_threshold = Inf for those pages.

@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Aug 17, 2023
@mortenpi mortenpi added this to the 1.0.0 milestone Aug 17, 2023
@mortenpi
Copy link
Member Author

Another option would be to have size_threshold_override :: Vector{Pair{String, Int}} = [page => threshold, ...], to set a special threshold for some pages. You could still do size_threshold_override = ["foo/bar.md" => nothing] to exclude the page completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant