Check local links as part of cross-references checks #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And produce proper docerrors (as opposed to warnings in HTMLWriter). Fix #2130.
This needed quite a bit of refactoring to move the link checking logic from HTMLWriter to CrossReferences. CrossReferences now replaces the local links & images it finds with
PageLink/LocalLink/LocalImageelements that the writers then should be able to safely use to generate the correct hyperlinks.I did notice that local link handling appears to be somewhat broken in LaTeXWriter. In some cases it seems to generate a link ID that probably doesn't exists (from the fragment), and in other cases the links just point to the
.mdfile. Not quite sure what to do here, and I'm inclined to leave the implementation broken for the time being.