Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcut to change theme #2097

Open
mortenpi opened this issue Apr 10, 2023 · 8 comments
Open

Keyboard shortcut to change theme #2097

mortenpi opened this issue Apr 10, 2023 · 8 comments
Labels
Format: HTML Related to the default HTML output Status: Speculative It's unknown if this is something that we wan't to do Type: Enhancement

Comments

@mortenpi
Copy link
Member

Similar to #2027, but for swapping between the light and dark themes.
@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Apr 10, 2023
@Hetarth02
Copy link
Contributor

Can you please provide some more details regarding this?

Like, how should it look like ideally or maybe a keyboard shortcut you have in mind?

@mortenpi
Copy link
Member Author

mortenpi commented Apr 16, 2023 •
edited
Loading

I guess this wouldn't really have a UI. But the UX here would be, yeah, you press the shortcut, and the the changes to the other theme. It should probably take into account the user's system theme preference too.

I don't really have any super specific ideas about the shortcut. Is there any prior-art anywhere? In VS Code Ctrl+K + Ctrl+T opens the theme selector, but that's not super-useful. I guess the main criterion is that it shouldn't clash with anything important, so e.g. Ctrl+T is out.

@Hetarth02
Copy link
Contributor

Yeah, we would really need to come up with a unique keyboard shortcut.

@Hetarth02
Copy link
Contributor

I will take a look into this.

@Hetarth02
Copy link
Contributor

@mortenpi I took a look into this, and found out that most websites don't tend to implement this kind of feature.

This could be due to the fact that, shortcuts are used for something which is likely to repeated many times.

And it is true, user won't be changing themes much often. So, I suggest we should think some more before starting to implement this feature.

@mortenpi
Copy link
Member Author

And it is true, user won't be changing themes much often.

I think that's a fair point. So I agree this wouldn't be a very high priority thing to do.

I do personally find myself swapping the themes quite a bit with Documenter (also because we can't share this preference across domains). So it was more motivated from a personal need. As such, though, it would be quite fine if the shortcut would be something pretty non-obvious and complicated.

@mortenpi mortenpi added the Status: Speculative It's unknown if this is something that we wan't to do label Apr 23, 2023
@Hetarth02
Copy link
Contributor

As such, though, it would be quite fine if the shortcut would be something pretty non-obvious and complicated.

Yes, from what I have observed. Any shortcut which includes a T in it would open a new tab.

@odow
Copy link
Collaborator

odow commented Nov 1, 2023

This seems like a low priority that adds complexity. I'd be in favor of closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Status: Speculative It's unknown if this is something that we wan't to do Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mortenpi @odow @Hetarth02