Overhaul remote repository link handling #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, I think I need to do another pass on the code, and look into adding a few new tests for edge cases. But generally, I think this is almost ready to go. Any eyes reviewing this would always be welcome. |
This reverts commit fed09a2.
|
Tests are passing. Time to merge this and deal with the consequences later. |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I have settled on the designed for this now. Basically, this aims to add a new
makedocsargument calledremotes(in additional torepo), that can be used to specifydirectory => repopairs, that will then be used to determine the remote source links.The code fixes the original issue, but is still WIP, since it now needs to be updated to match the new docs & design. Feedback or questions would be most welcome, in particular on the explainer docs in
remote-links.md.This will fix #1975, and should pretty much unblock 1.0.