Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct deployment via GitHub Actions #1959

Open
simonbyrne opened this issue Sep 30, 2022 · 3 comments
Open

Direct deployment via GitHub Actions #1959

simonbyrne opened this issue Sep 30, 2022 · 3 comments
Labels
Status: Speculative It's unknown if this is something that we wan't to do

Comments

@simonbyrne
Copy link
Contributor

simonbyrne commented Sep 30, 2022

GitHub Pages are now deployed via GitHub Actions, see https://github.blog/2022-08-10-github-pages-now-uses-actions-by-default/ for more details. You can see the current Action which does this for Documenter.jl here:
https://github.com/JuliaDocs/Documenter.jl/actions/workflows/pages/pages-build-deployment

This means that instead of Documenter pushing to the gh-pages branch, it should be possible to deploy directly via GitHub Actions. It's not clear how this would work for keeping versioned docs around (would it still need a branch to keep track of this? could they be stored as artifacts?)

@simonbyrne
Copy link
Contributor Author

@mortenpi mortenpi added the Status: Speculative It's unknown if this is something that we wan't to do label Oct 1, 2022
@mortenpi
Copy link
Member

mortenpi commented Oct 1, 2022

This is interesting. But I agree that the uploaded artifact replacing the whole Pages contents (like GitLab) is a problem. And I didn't see any way to access the existing files? I suppose we could store things as artifacts, but I think that can have issues too -- how do you know which one is the latest? And also, they expire and get deleted after a while.

This is probably less of an issue, but you'll also lose the history on the gh-pages branch, which can be useful when debugging, or restoring things of something goes very wrong.

@simonbyrne
Copy link
Contributor Author

Yeah, in that case I'm not sure it's worth it? To be honest, I only reason I noticed this at all is because I was updating MPI.jl which has a huge CI matrix, and that was blocking the deployment jobs from being run. One thing we could do is move the deployment to be an extra explicit step in the documenter action though (without changing the current workflow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Speculative It's unknown if this is something that we wan't to do
Projects
None yet
Development

No branches or pull requests

2 participants