Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title margin of admonitions in LaTeXWriter #1955

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

odow
Copy link
Collaborator

@odow odow commented Sep 29, 2022

Closes #1946

The default should be 0mm, so it must be some package that's mucking with this? I couldn't find the exact height is being modified, so let's just check how this looks in the PDFs created by CI. It looks okay locally.

@odow odow added the Format: LaTeX Related to the LaTeX / PDF output label Sep 29, 2022
@odow
Copy link
Collaborator Author

odow commented Sep 29, 2022

Better?

image

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely looks better. You're just narrowing the title bar? I think in an ideal world there would be a little bit more padding above and below the text (so keep the old height I guess, but center the text vertically), but this is better than the status quo. Happy to merge as is if you're happy with it.

@odow
Copy link
Collaborator Author

odow commented Sep 30, 2022

You're just narrowing the title bar?

I think some other package is mucking with the margins above the title, so it's not that the title isn't centered (it looks like it has valign=center for the title), it's that there is extra space above. So this gets things back to the default.

We can go the other way and try to increase the margin underneath the title if you like. I don't have a preference.

@mortenpi
Copy link
Member

Hmm. Could we try removing just 1mm from the top and adding 1mm to the bottom, if we can mix it like that easily?

@odow
Copy link
Collaborator Author

odow commented Sep 30, 2022

Better?

image

@mortenpi
Copy link
Member

Yep, I think that looks perfect!

@mortenpi mortenpi merged commit a75260d into JuliaDocs:master Sep 30, 2022
@odow odow deleted the od/fix-admonition-height branch September 30, 2022 01:16
@mortenpi
Copy link
Member

Thank you for keeping on getting nerdsniped with this stuff 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly center the adminition title vertically in LaTeX output
2 participants