-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix title margin of admonitions in LaTeXWriter #1955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely looks better. You're just narrowing the title bar? I think in an ideal world there would be a little bit more padding above and below the text (so keep the old height I guess, but center the text vertically), but this is better than the status quo. Happy to merge as is if you're happy with it.
I think some other package is mucking with the margins above the title, so it's not that the title isn't centered (it looks like it has We can go the other way and try to increase the margin underneath the title if you like. I don't have a preference. |
Hmm. Could we try removing just 1mm from the top and adding 1mm to the bottom, if we can mix it like that easily? |
Yep, I think that looks perfect! |
Thank you for keeping on getting nerdsniped with this stuff 😆 |
Closes #1946
The default should be 0mm, so it must be some package that's mucking with this? I couldn't find the exact height is being modified, so let's just check how this looks in the PDFs created by CI. It looks okay locally.