Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce padding in some container elements #1818

Merged
merged 6 commits into from
May 11, 2022
Merged

Conversation

mortenpi
Copy link
Member

Reduces and makes the padding more consistent between various container elements. For admonitions, it changes as follows:

padding-admonition-old
padding-admonition-new

It also makes the padding in the docstrings consistent with the admonitions, although I left the content vertical padding a little higher, since docstrings often start with a code block, and 0.5rem looked a little too narrow then:

padding-docstrings-old
padding-docstrings-new

For code blocks, the vertical padding is slightly reduced, but left padding actually increases (to be consistent with admonitions and docstrings):

padding-code-old
padding-code-new

@KristofferC: what do you think? Not quite as narrow as you suggested, but perhaps a good compromise? Close #1814.

@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels May 11, 2022
@KristofferC
Copy link
Member

Yes, looks a lot better to my eyes. Thanks!

@mortenpi mortenpi merged commit 8657ff9 into master May 11, 2022
@mortenpi mortenpi deleted the mp/padding-bikeshed branch May 11, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive padding in some cases (bikeshedding)
2 participants