Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message to only print fatal errors #1816

Merged
merged 4 commits into from
May 11, 2022

Conversation

ericphanson
Copy link
Contributor

Currently it prints all errors, which can be confusing (makes it look like strict options aren't working correctly)

@mortenpi
Copy link
Member

Thanks, yea, this makes more sense. The patch LGTM, so I am not sure where the test failures are coming from. Do you also get them locally? Also, could you add a small CHANGELOG note for this?

@ericphanson
Copy link
Contributor Author

I was able to repro locally. For some reason the test output is suppressed, but I was able to edit stuff to uncover an undefined variable exception- which was then obvious in retrospect because I use c later without defining it. Should be fixed, along with a changelog addition.

@mortenpi
Copy link
Member

Looks great, thank you!

@mortenpi mortenpi merged commit 5fbb7b8 into JuliaDocs:master May 11, 2022
@ericphanson ericphanson deleted the eph/error-message branch May 11, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants