Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version option to LaTeX format #1795

Merged
merged 11 commits into from
Apr 16, 2022
Merged

Add version option to LaTeX format #1795

merged 11 commits into from
Apr 16, 2022

Conversation

mortenpi
Copy link
Member

@inkydragon This is what I had in mind as a stopgap solution for the version, until we support it for all formats in makedocs. Do the changes look good to you?

@mortenpi mortenpi added Type: Enhancement Format: LaTeX Related to the LaTeX / PDF output labels Apr 11, 2022
@inkydragon
Copy link

inkydragon commented Apr 12, 2022

Looks good. Build locally works well.


And ...

let tag = get(ENV, "TRAVIS_TAG", "")
if occursin(Base.VERSION_REGEX, tag)
v = VersionNumber(tag)
name *= "-$(v.major).$(v.minor).$(v.patch)"
end
end

            if occursin(Base.VERSION_REGEX, settings.version)
                v = VersionNumber(settings.version)
                name *= "-$(v.major).$(v.minor).$(v.patch)"
            end

@mortenpi
Copy link
Member Author

Good catch @inkydragon!

@mortenpi mortenpi merged commit a162bf4 into master Apr 16, 2022
@mortenpi mortenpi deleted the mp/latex-version branch April 16, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants