fix DocTestFilters = nothing in at-meta
#1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ```` ```@meta DocTestFilters = nothing ``` ```` as [suggested in the docs](https://juliadocs.github.io/Documenter.jl/stable/man/doctests/#Filtering-Doctests), I get ``` ERROR: LoadError: MethodError: no method matching occursin(::Nothing, ::SubString{String}) Closest candidates are: occursin(::Union{AbstractChar, AbstractString}, ::AbstractString) at strings/search.jl:622 occursin(::Regex, ::SubString; offset) at regex.jl:269 occursin(::Regex, ::AbstractString; offset) at regex.jl:264 ``` To me, it looks like this is the reason for this behavior.
KristofferC
reviewed
Sep 15, 2021
src/DocTests.jl
Outdated
| @@ -276,7 +276,9 @@ end | |||
| function filter_doctests(strings::NTuple{2, AbstractString}, | |||
| doc::Documents.Document, meta::Dict) | |||
| meta_block_filters = get(meta, :DocTestFilters, []) | |||
| meta_block_filters == nothing && meta_block_filters == [] | |||
| if meta_block_filters === nothing | |||
There was a problem hiding this comment.
meta_block_filters == nothing && (meta_block_filters = [])
is probably what was intended
There was a problem hiding this comment.
Yes, I think so, too. However, I thought my version was a bit more readable (which seems to be fine given this typo)
There was a problem hiding this comment.
I think this is the standard way of doing it as seen by the original code. It is just as easy to write meta_block_filters == [] in your version.
KristofferC
reviewed
Sep 15, 2021
Co-authored-by: Kristoffer Carlsson <[email protected]>
benlorenz
added a commit
to benlorenz/Documenter.jl
that referenced
this pull request
Sep 19, 2023
mortenpi
pushed a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
as suggested in the docs, I get
To me, it looks like this is the reason for this behavior.