Handle faulty doctest keyword arguments better #1557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does two things:
Meta.parse
fails to parse the doctest keyword arguments (x-ref Doctest syntax error, how to find out where? #1556), it will gracefully report a doctest failure and move on (rather than makingmakedocs
throw an unhelpfulMeta.ParseError
).strict = true
. Currently we just print a warning and move on.Will close #1556. @fingolfin, do you mind trying out this branch for your case?