use valid identifiers for sandbox module names #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows base julia to switch to `var""` printing for invalid identifiers and still have Documenter work with multiple julia versions.
mortenpi
reviewed
Mar 1, 2021
There was a problem hiding this comment.
I guess, technically, the gensym()d one is no longer guaranteed to be unique, since gensym() would just check for the existence of ##NNN but not __doctest__NNN? I don't think this will be an issue in practice though, since that's how the named ones work anyway.
Basically, LGTM, other than the two suggestions. We can get a patch release out as soon as this is merged to update Documenter in the Julia repo.
Co-authored-by: Morten Piibeleht <[email protected]>
mortenpi
pushed a commit
that referenced
this pull request
Mar 2, 2021
(cherry picked from commit 6d1232d)
This was referenced Mar 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows base julia to switch to
var""printing for invalid identifiers (JuliaLang/julia#39841) and still have Documenter work with multiple julia versions.