Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script.src for MathJax3 #1428

Closed
ianqsong opened this issue Oct 3, 2020 · 2 comments · Fixed by #1430
Closed

script.src for MathJax3 #1428

ianqsong opened this issue Oct 3, 2020 · 2 comments · Fixed by #1430
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Milestone
0.25.3

Comments

@ianqsong
Copy link
Contributor

ianqsong commented Oct 3, 2020

The version is currently specified and fixed on 3.0.5 for MathJax3 (source), but the lastest is on 3.1.2.
It seems to me that https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-svg.js is better as recommended by mathjaxdoc.
So I was wondering if it be better to have the script.src as a user-defined argument.
@ianqsong ianqsong mentioned this issue Oct 3, 2020
Closed
@mortenpi mortenpi added Format: HTML Related to the default HTML output Status: Speculative It's unknown if this is something that we wan't to do Type: Enhancement labels Oct 3, 2020
@mortenpi
Copy link
Member

mortenpi commented Oct 3, 2020

I do strongly prefer deploying an exact version of a JS dependency. Even though MathJax should be following SemVer, there's always a possibility that a minor version change breaks something for someone, and so all existing already deployed docs suddenly break.

That said:

  • We could definitely make the version and/or the URL customizable -- PRs to that effect are most welcome.
  • I need to bump the versions of JS deps anyway, which should happen in 0.26.

This was referenced Oct 4, 2020
Closed
Merged
@ianqsong
Copy link
Contributor Author

ianqsong commented Oct 4, 2020

Please refer to PR #1430.

@mortenpi mortenpi removed the Status: Speculative It's unknown if this is something that we wan't to do label Oct 12, 2020
@mortenpi mortenpi modified the milestones: 0.25.2, 0.25.3 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Milestone
0.25.3
Development

Successfully merging a pull request may close this issue.

Allow specifying URLs for LaTeX engines
2 participants
@mortenpi @ianqsong