Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit on Github" link points to master instead of custom devbranch #1375

Closed
vlandau opened this issue Jul 23, 2020 · 5 comments
Closed

"Edit on Github" link points to master instead of custom devbranch #1375

vlandau opened this issue Jul 23, 2020 · 5 comments

Comments

@vlandau
Copy link
Contributor

vlandau commented Jul 23, 2020

I recently changed the primary branch for Omniscape.jl from master to main, with the plan to eventually get rid of the master branch. Everything works great but I noticed that the "Edit on GitHub" button that appears on the docs page still points to master. If possible, it would be great if this link could be made to point to the devbranch.

@mortenpi
Copy link
Member

Passing edit_link = "main" to HTML(...) should fix that. Unfortunately, it's necessary to make that change in two places, because makedocs does not know anything the deploydocs options (and vice versa).

@vlandau
Copy link
Contributor Author

vlandau commented Jul 24, 2020

What are the two places where I need to make the change? Thanks for your help!

@mortenpi
Copy link
Member

mortenpi commented Jul 25, 2020

One place is devbranch, which you already set up. The other one is adding edit_link = "main" to here: https://github.com/Circuitscape/Omniscape.jl/blob/86f4549341d144e4348044510cf2dc15cb3422b1/docs/make.jl#L4-L6

@vlandau
Copy link
Contributor Author

vlandau commented Aug 6, 2020

Thanks so much @mortenpi! I appreciate the help. I will try this now and close this issue once I'ts working.

@vlandau
Copy link
Contributor Author

vlandau commented Aug 6, 2020

Alright, everything is working! (btw the argument name was edit_branch not edit_link, but figured that out easily enough from the stack trace). Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants