Remove exported/unexported ordering override #1323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three reasons I think this should be removed:
1) The documentation for
@index
states:which is not true due to the split introduced into exported/unexported bindings only in
@autodocs
.2) The documentation contains an example which shows how to use the
Private
andPublic
field with@autodocs
to create the currently implemented behaviour.3) Offering the possibility to define an
Order
, but overridden it by something that is not documented is quite surprising and results in bug reports.Fixes: #964