Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change away from red inline code color #1222

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Change away from red inline code color #1222

merged 2 commits into from
Jan 7, 2020

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Jan 5, 2020

Goes from

from

to

to

Close #1212.

@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Jan 5, 2020
@mortenpi mortenpi added this to the 0.24.4 milestone Jan 5, 2020
@mortenpi
Copy link
Member Author

mortenpi commented Jan 5, 2020

I'm a bit on the fence about whether we should do a similar change to the dark theme too. I find that the red is not quite as distracting there:
dark

@mortenpi mortenpi merged commit 278cf3b into master Jan 7, 2020
@mortenpi mortenpi deleted the mp/code-color branch January 7, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Milestone
0.24.4
Development

Successfully merging this pull request may close these issues.

Why is inlined code rendered in red?
1 participant
@mortenpi