Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User and IdentitesOnly lines to the generated SSH config #1171

Merged
merged 3 commits into from
Nov 9, 2019

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Nov 8, 2019

I am trying to set up documentation generation on CircleCI, and it seems that these entries are required for the git push to work, otherwise I get an error about the key not having write privileges (in fact, as I can see from the last access info on GitHub, it wasn't even used).

I am not sure what is the difference between Circle and Travis (where these entries are not required), so it would be great if someone more knowledgeable took a look at it, so that this PR doesn't break anything.

@mortenpi mortenpi added this to the 0.24.0 milestone Nov 8, 2019
@mortenpi
Copy link
Member

mortenpi commented Nov 8, 2019

This should have no effect when running on Travis, so LGTM. Thanks, @fjarri!

@mortenpi
Copy link
Member

mortenpi commented Nov 8, 2019

I am trying to set up documentation generation on CircleCI, and it seems that these entries are required for the git push to work, otherwise I get an error about the key not having write privileges (in fact, as I can see from the last access info on GitHub, it wasn't even used).

I wonder if CircleCI has a default SSH key generated that gets precedence over ours?

@fjarri
Copy link
Contributor Author

fjarri commented Nov 8, 2019

It does have a read-only key it uses to check out the repo, so maybe that's the reason. Travis seems to only have a single read/write key, judging by "Deploy Keys" settings tab in my projects. I can't change the access preferences now, and I don't remember if I could select them when I connected CircleCI.

@mortenpi
Copy link
Member

mortenpi commented Nov 9, 2019

It does have a read-only key it uses to check out the repo, so maybe that's the reason.

That's probably it then. SSH manages to log in with that one, so it never gets around to trying the write key.

@mortenpi mortenpi merged commit 6ca2f08 into JuliaDocs:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants