Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase search result prominence for close matches in result titles #1112

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

IanButterworth
Copy link
Contributor

@IanButterworth IanButterworth commented Aug 24, 2019

I tested this through Chrome's DevTools (breakpoint before the function runs, adding this change, then running the page so that the index is generated with this change)

It makes search queries that closely match the result title rank much higher.
For "Macros" and "Arrays" queries in searching the base docs it makes those sections 1st or 2nd, whereas they're currently way down in the list.

Fixes #631 and #1110

@mortenpi mortenpi added this to the 0.24.0 milestone Aug 25, 2019
@mortenpi
Copy link
Member

LGTM. Thanks, @ianshmean! It will be a short while before this will actually show up on Julia's stable docs (either with 1.3 of 1.4).

@IanButterworth
Copy link
Contributor Author

@mortenpi I know this is probably frowned upon, but would JuliaLang/docs.julialang.org#9 be acceptable? Seems like this fix would be helpful retroactively

Obviously just a suggestion, as it would break the rules..

@IanButterworth
Copy link
Contributor Author

IanButterworth commented Aug 25, 2019

Perhaps a sensible approach would be to see how it goes for new releases first before deciding whether to do anything retroactive..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exact page title match should be ranked first in the search results
2 participants