Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize PR cross references #1070

Closed
tk3369 opened this issue Jul 17, 2019 · 1 comment
Closed

Generalize PR cross references #1070

tk3369 opened this issue Jul 17, 2019 · 1 comment
Labels
Type: Enhancement

Comments

@tk3369
Copy link

tk3369 commented Jul 17, 2019

Currently, it's hardcoding PR references to github.com. So it doesn't work for GitHub Enterprise or other providers. It would be nice if we can configure the url reference.

Documenter.jl/src/CrossReferences.jl

Line 223 in bf05fee

"https://github.com/$(doc.internal.remote)/issues/$num"

@mortenpi
Copy link
Member

This was solved by #1808.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mortenpi @tk3369