Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logo link URLs #1005

Merged
merged 3 commits into from
May 9, 2019
Merged

Improve logo link URLs #1005

merged 3 commits into from
May 9, 2019

Conversation

mortenpi
Copy link
Member

  • Instead of pointing to potentially non-existent /index.md, the logo will now point to the top most page in the navigation menu.
  • index.html no longer appears in the URL when pretty URLs are enabled.

This is technically slightly behavior-changing, so I'd leave it for 0.23.

@mortenpi mortenpi added this to the 0.23.0 milestone Apr 28, 2019
@mortenpi mortenpi requested a review from fredrikekre April 28, 2019 05:57
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix IMO :)

@mortenpi
Copy link
Member Author

It technically changes behaviour if you don't have the first item pointing to index.md (although it is an extremely unlikely corner case). Will merge after #1004, so that there is no need to do backports.

@mortenpi mortenpi merged commit 13d6ee6 into master May 9, 2019
@mortenpi mortenpi deleted the mp/logo-href branch May 9, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants