diff --git a/CHANGELOG.md b/CHANGELOG.md index 47b831c740..ef7eec146e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## Version `v0.27.25` * ![Bugfix][badge-bugfix] Page headings are now correctly escaped in `LaTeXWriter`. ([#2134][github-2134]) +* ![Bugfix][badge-bugfix] Compiling the dark theme with Sass no longer emits deprecation warnings about `!global` assignments. ([#1766][github-1766], [#1983][github-1983], [#2145][github-2145]) ## Version `v0.27.24` @@ -1058,6 +1059,7 @@ [github-1759]: https://github.com/JuliaDocs/Documenter.jl/pull/1759 [github-1760]: https://github.com/JuliaDocs/Documenter.jl/issues/1760 [github-1762]: https://github.com/JuliaDocs/Documenter.jl/pull/1762 +[github-1766]: https://github.com/JuliaDocs/Documenter.jl/issues/1766 [github-1770]: https://github.com/JuliaDocs/Documenter.jl/issues/1770 [github-1771]: https://github.com/JuliaDocs/Documenter.jl/pull/1771 [github-1772]: https://github.com/JuliaDocs/Documenter.jl/issues/1772 @@ -1102,8 +1104,10 @@ [github-1886]: https://github.com/JuliaDocs/Documenter.jl/pull/1886 [github-1908]: https://github.com/JuliaDocs/Documenter.jl/pull/1908 [github-1909]: https://github.com/JuliaDocs/Documenter.jl/pull/1909 +[github-1983]: https://github.com/JuliaDocs/Documenter.jl/issues/1983 [github-2018]: https://github.com/JuliaDocs/Documenter.jl/pull/2018 [github-2134]: https://github.com/JuliaDocs/Documenter.jl/pull/2134 +[github-2145]: https://github.com/JuliaDocs/Documenter.jl/pull/2145 [julia-38054]: https://github.com/JuliaLang/julia/issues/38054 diff --git a/assets/html/scss/documenter-dark.scss b/assets/html/scss/documenter-dark.scss index 3c58bae5b1..6477f5197b 100644 --- a/assets/html/scss/documenter-dark.scss +++ b/assets/html/scss/documenter-dark.scss @@ -34,6 +34,11 @@ $admonition-background: ( 'danger': $background, 'compat': $background ); $admonition-header-background: ('default': $grey); +// These would normally get initialized in _admonition.scss. However, since we are not +// loading it on the top level, we need to set them here too to avoid deprecation warnings. +// https://github.com/JuliaDocs/Documenter.jl/issues/1766 +$admonition-header-color: (); +$admonition-body-color: (); $body-size: 16px; $documenter-sidebar-background: $grey-darker; diff --git a/assets/html/themes/documenter-dark.css b/assets/html/themes/documenter-dark.css index 0bf1af7d5e..26a02d0f1f 100644 --- a/assets/html/themes/documenter-dark.css +++ b/assets/html/themes/documenter-dark.css @@ -7143,33 +7143,52 @@ html.theme--documenter-dark { background-color: #282f2f; border-color: #5e6d6f; } html.theme--documenter-dark .admonition.is-default > .admonition-header { - background-color: #5e6d6f; } + background-color: #5e6d6f; + color: #fff; } + html.theme--documenter-dark .admonition.is-default > .admonition-body { + color: #fff; } html.theme--documenter-dark .admonition.is-info { background-color: #282f2f; border-color: #024c7d; } html.theme--documenter-dark .admonition.is-info > .admonition-header { - background-color: #024c7d; } + background-color: #024c7d; + color: #fff; } + html.theme--documenter-dark .admonition.is-info > .admonition-body { + color: #fff; } html.theme--documenter-dark .admonition.is-success { background-color: #282f2f; border-color: #008438; } html.theme--documenter-dark .admonition.is-success > .admonition-header { - background-color: #008438; } + background-color: #008438; + color: #fff; } + html.theme--documenter-dark .admonition.is-success > .admonition-body { + color: #fff; } html.theme--documenter-dark .admonition.is-warning { background-color: #282f2f; border-color: #ad8100; } html.theme--documenter-dark .admonition.is-warning > .admonition-header { - background-color: #ad8100; } + background-color: #ad8100; + color: #fff; } + html.theme--documenter-dark .admonition.is-warning > .admonition-body { + color: #fff; } html.theme--documenter-dark .admonition.is-danger { background-color: #282f2f; border-color: #9e1b0d; } html.theme--documenter-dark .admonition.is-danger > .admonition-header { - background-color: #9e1b0d; } + background-color: #9e1b0d; + color: #fff; } + html.theme--documenter-dark .admonition.is-danger > .admonition-body { + color: #fff; } html.theme--documenter-dark .admonition.is-compat { background-color: #282f2f; border-color: #137886; } html.theme--documenter-dark .admonition.is-compat > .admonition-header { - background-color: #137886; } + background-color: #137886; + color: #fff; } + html.theme--documenter-dark .admonition.is-compat > .admonition-body { + color: #fff; } html.theme--documenter-dark .admonition-header { + color: #fff; background-color: #5e6d6f; align-items: center; font-weight: 700; @@ -7240,6 +7259,7 @@ html.theme--documenter-dark { box-shadow: 0 0 10px rgba(0, 0, 0, 0.3); z-index: 999; background-color: #282f2f; + color: #fff; border-bottom: 3px solid #9e1b0d; padding: 10px 35px; text-align: center;