We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For in-place methods my own mental picture is that it's expected that the cache arrays are touched, but that other input is left intact. That's why in-place methods often allow for extra cache variables when things should not allocate at all. However, these lines directly modify the input state, and as a result the parameter can drift simply from evaluations of Hv. If this is intentional, I think it should be documented. https://github.com/JuliaDiff/SparseDiffTools.jl/blob/7b271eddbe4394fb63d10ddeb157be843051bd6b/src/differentiation/jaches_products.jl#L97C4-L101C18
The text was updated successfully, but these errors were encountered:
Avoid mutation on user x
54ce5d5
Fixes #265
Successfully merging a pull request may close this issue.
For in-place methods my own mental picture is that it's expected that the cache arrays are touched, but that other input is left intact. That's why in-place methods often allow for extra cache variables when things should not allocate at all. However, these lines directly modify the input state, and as a result the parameter can drift simply from evaluations of Hv. If this is intentional, I think it should be documented.
https://github.com/JuliaDiff/SparseDiffTools.jl/blob/7b271eddbe4394fb63d10ddeb157be843051bd6b/src/differentiation/jaches_products.jl#L97C4-L101C18
The text was updated successfully, but these errors were encountered: