Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point arithmetic 101 - it doesn't add up! aka Don't touch user input without telling them the rules #265

Closed
pkofod opened this issue Oct 10, 2023 · 0 comments · Fixed by #280

Comments

@pkofod
Copy link

pkofod commented Oct 10, 2023

For in-place methods my own mental picture is that it's expected that the cache arrays are touched, but that other input is left intact. That's why in-place methods often allow for extra cache variables when things should not allocate at all. However, these lines directly modify the input state, and as a result the parameter can drift simply from evaluations of Hv. If this is intentional, I think it should be documented.
https://github.com/JuliaDiff/SparseDiffTools.jl/blob/7b271eddbe4394fb63d10ddeb157be843051bd6b/src/differentiation/jaches_products.jl#L97C4-L101C18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant