From 51f25823ff2fd5466333ca6a76d97af50c00e2e0 Mon Sep 17 00:00:00 2001 From: David Widmann Date: Tue, 19 Mar 2024 13:46:53 +0100 Subject: [PATCH 1/2] Add downstream tests --- .github/workflows/IntegrationTest.yml | 57 +++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 .github/workflows/IntegrationTest.yml diff --git a/.github/workflows/IntegrationTest.yml b/.github/workflows/IntegrationTest.yml new file mode 100644 index 0000000..b7b339b --- /dev/null +++ b/.github/workflows/IntegrationTest.yml @@ -0,0 +1,57 @@ +name: IntegrationTest + +on: + push: + branches: [master] + tags: [v*] + pull_request: + +concurrency: + # Skip intermediate builds: always. + # Cancel intermediate builds: only if it is a pull request build. + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }} + +jobs: + test: + name: ${{ matrix.package.repo }}/${{ matrix.package.group }} + runs-on: ubuntu-latest + env: + GROUP: ${{ matrix.package.group }} + strategy: + fail-fast: false + matrix: + package: + - {user: JuliaDiff, repo: AbstractDifferentiation.jl, group: All} + - {user: JuliaDiff, repo: ForwardDiff.jl, group: All} + - {user: JuliaDiff, repo: ReverseDiff.jl, group: All} + - {user: tpapp, repo: LogDensityProblemsAD.jl, group: All} + steps: + - uses: actions/checkout@v3 + - uses: julia-actions/setup-julia@v1 + with: + version: 1 + arch: x64 + - uses: julia-actions/julia-buildpkg@v1 + - name: Clone Downstream + uses: actions/checkout@v3 + with: + repository: ${{ matrix.package.user }}/${{ matrix.package.repo }} + path: downstream + - name: Load this and run the downstream tests + shell: julia --color=yes --project=downstream {0} + run: | + using Pkg + try + # force it to use this PR's version of the package + Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps + Pkg.update() + Pkg.test() # resolver may fail with test time deps + catch err + err isa Pkg.Resolve.ResolverError || rethrow() + # If we can't resolve that means this is incompatible by SemVer and this is fine + # It means we marked this as a breaking change, so we don't need to worry about + # Mistakenly introducing a breaking change, as we have intentionally made one + @info "Not compatible with this release. No problem." exception=err + exit(0) # Exit immediately, as a success + end From 20f8a4e486cd6214bd7438dd0393256a03f2d45f Mon Sep 17 00:00:00 2001 From: David Widmann Date: Thu, 21 Mar 2024 11:56:46 +0100 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> --- .github/workflows/IntegrationTest.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/IntegrationTest.yml b/.github/workflows/IntegrationTest.yml index b7b339b..e3fedaf 100644 --- a/.github/workflows/IntegrationTest.yml +++ b/.github/workflows/IntegrationTest.yml @@ -27,14 +27,14 @@ jobs: - {user: JuliaDiff, repo: ReverseDiff.jl, group: All} - {user: tpapp, repo: LogDensityProblemsAD.jl, group: All} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: julia-actions/setup-julia@v1 with: version: 1 arch: x64 - uses: julia-actions/julia-buildpkg@v1 - name: Clone Downstream - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: ${{ matrix.package.user }}/${{ matrix.package.repo }} path: downstream