Avoid unnecessary keyword arguments check in fallback rrule #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Mar 8, 2021
oxinabox
reviewed
Mar 8, 2021
oxinabox
reviewed
Mar 8, 2021
Keno
force-pushed
the
kf/fallbackvarargs
branch
from
fd3ada6 to
2174b67
Compare
The expansion `rrule(::Any, ::Vararg{Any}; kwargs...)` actually
generates two methods. One along the lines of:
```
(::typeof(Core.kwfunc(rrule))(kwargs, ::typeof(rrule), ::Any, ::Vararg{Any}) = nothing
```
and the other that just calls it:
```
rrule(a::Any, b::Vararg{Any}) = Core.kwfunc(rrule)(NamedTuple{}(), a, b...)
```
The compiler handles this fallback well, since it's used all over the place,
but the cost to infer it is non-zero. Of course, in the AD use case, this
fallback method is visited literally on every call, so saving a tiny amount
of inference/compile time actually leads to noticable improvements over
a whole AD problem.
Keno
force-pushed
the
kf/fallbackvarargs
branch
from
2174b67 to
2ead553
Compare
|
@oxinabox should be good to go |
|
Will review and merge tomorrow |
oxinabox
reviewed
Mar 24, 2021
oxinabox
reviewed
Mar 24, 2021
oxinabox
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expansion
rrule(::Any, ::Vararg{Any}; kwargs...)actuallygenerates two methods. One along the lines of:
and the other that just calls it:
The compiler handles this fallback well, since it's used all over the place,
but the cost to infer it is non-zero. Of course, in the AD use case, this
fallback method is visited literally on every call, so saving a tiny amount
of inference/compile time actually leads to noticable improvements over
a whole AD problem.