You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
functionfrule((_, ΔA, ΔB, Δz), ::typeof(muladd), A, B, z)
Ω =muladd(A, B, z)
return Ω, ΔA * B .+ A * ΔB .+ Δz
end
is Any typed. This is in general undesirable, because an frule this wide may be worse than the frule that would have been generated using AD recursion. In particular, this rule catches ChainRulesCore's methods for muladd on ZeroTangent which would otherwise have been trivial. I'd be good to narrow these types.
The text was updated successfully, but these errors were encountered:
The frule here:
ChainRules.jl/src/rulesets/Base/arraymath.jl
Lines 213 to 216 in f0095e0
is
Any
typed. This is in general undesirable, because an frule this wide may be worse than the frule that would have been generated using AD recursion. In particular, this rule catches ChainRulesCore's methods formuladd
on ZeroTangent which would otherwise have been trivial. I'd be good to narrow these types.The text was updated successfully, but these errors were encountered: