Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle uplo argument for Symmetric #178

Closed
oxinabox opened this issue Apr 28, 2020 · 5 comments · Fixed by #182
Closed

handle uplo argument for Symmetric #178

oxinabox opened this issue Apr 28, 2020 · 5 comments · Fixed by #182

Comments

@oxinabox
Copy link
Member

Zygote handles the 2 arg function for Symmetric
ChainRules rightnow only handles the 1 arg function

@sethaxen
Copy link
Member

Should be easy to transfer from Zygote. Actually, of all of the Symmetric/Hermitian rules in Zygote, are there any that just should not be in ChainRules?

@oxinabox
Copy link
Member Author

Nope, they all should be.
Only thing that should not be really is things that need to call back into AD (so unrestricted higher ordee functions)
We know how to support that but haven't yet.

Also nonholomorphic things

@sethaxen
Copy link
Member

Okay, yeah the power series defaults do call pullback internally, so I'll hold off on any transfer for now.

@sethaxen
Copy link
Member

sethaxen commented May 1, 2020

I will transfer over the rrules for the constructor though. Would like to do Hermitian at the same time. How in ChainRules should I test an rrule with complex numbers?

@willtebbutt
Copy link
Member

Same as you would with real numbers, just replace everything with complex numbers, including the seed. to_vec should just handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants