Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Revise asserts in JuliaInterpreter on 1.9 #570

Open
KristofferC opened this issue Apr 14, 2023 · 3 comments
Open

Testing Revise asserts in JuliaInterpreter on 1.9 #570

KristofferC opened this issue Apr 14, 2023 · 3 comments

Comments

@KristofferC
Copy link
Member

From Revise tests:

(jl_Sw1Slv) pkg> add Revise; test Revise
...
beginning signatures tests
julia: /source/src/jltypes.c:2005: jl_reinstantiate_inner_types: Assertion `ndt->types == ((void *)0)' failed.

[9] signal (6.-6): Aborted
in expression starting at /home/pkgeval/.julia/packages/Revise/Kw99o/test/sigtest.jl:106
gsignal at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7f0674ecc40e)
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
jl_reinstantiate_inner_types at /source/src/jltypes.c:2005
jl_f__typebody at /source/src/builtins.c:1731
_jl_invoke at /source/src/gf.c:2739 [inlined]
ijl_apply_generic at /source/src/gf.c:2940
jl_apply at /source/src/julia.h:1879 [inlined]
do_apply at /source/src/builtins.c:730
maybe_evaluate_builtin at /home/pkgeval/.julia/packages/JuliaInterpreter/ktCFr/src/builtins.jl:114

https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/9aa7669_vs_7b39515/Revise.primary.log

@timholy
Copy link
Member

timholy commented Apr 14, 2023

Can you explain why you suspect this is a JuliaInterpreter bug and not a Julia bug?

@KristofferC
Copy link
Member Author

No, I just know we call some internal stuff in JuliaInterpreter so I thought I would open it here first. If it turns out to be a Julia bug, we can transfer it there but I think we need to do a bit more work for that first.

At least, that is how I look at things, if you use a bunch of internals and your package starts failing / asserting, you, at least, need to put in the effort to show that the problem is indeed with Julia, and not your usage of the internals. I haven't put in that work yet.

@timholy
Copy link
Member

timholy commented Apr 14, 2023

Excellent, thanks for clarifying. Good instincts too (as always).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants