Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary builds cannot step into source code for stdlib functions due to bad location info #144

Closed
KristofferC opened this issue Mar 14, 2019 · 3 comments

Comments

@KristofferC
Copy link
Member

Due to JuliaLang/julia#26314 we are getting spurious location info for functions in the stdlib:

julia> using LinearAlgebra

julia> import JuliaInterpreter.enter_call

julia> enter_call(norm, [1,2])
Frame for norm(itr) in LinearAlgebra at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.1\LinearAlgebra\src\generic.jl:448
  1 448  1%1 = (#self#)(itr, 2)
  2 448  └──      return %1
itr = [1, 2]

If not too difficult, we could perhaps detect this and rewrite the prefix to Sys.STDLIB. Best would of course be to fix it in Base but not sure how hard that is.

@pfitzseb
Copy link
Member

Should CodeTracking handle this, maybe?

@timholy
Copy link
Member

timholy commented Mar 15, 2019

But this only works if the user is running Revise; there is still room for #146, though it would be better to call whereis on the method and then correct the path as needed.

@KristofferC
Copy link
Member Author

#146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants