consistency of [@]descend_code_[typed|warntype] with InteractiveUtils
#587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would expect these macros to behave like their InteractiveUtils counterparts and show the annotated IR instead of annotated source. The behavior of `[@]descend` remains the same but is now decoupled from `descend_code_typed`.
timholy
approved these changes
Aug 15, 2024
|
Since it only really affects interactive use, I would agree that this should be fine in a minor release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would expect these macros to behave like their InteractiveUtils
counterparts and show the annotated IR instead of annotated source. The
behavior of
[@]descendremains the same but is now decoupled fromdescend_code_typed.