Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in syntax between savecube and savedataset #345

Open
Qfl3x opened this issue Oct 18, 2023 · 2 comments
Open

Inconsistency in syntax between savecube and savedataset #345

Qfl3x opened this issue Oct 18, 2023 · 2 comments

Comments

@Qfl3x
Copy link
Contributor

Qfl3x commented Oct 18, 2023

Why is the path savecube a "normal" argument, while path in savedataset a kwarg?
@lazarusA
Copy link
Collaborator

Indeed. Things should be unified. There is an open issue about it as well: #309. Some work needs to be done also here.

@Qfl3x
Copy link
Contributor Author

Qfl3x commented Oct 19, 2023

Another thing is that path isn't a mandatory kwarg, and it has a default value of "", wouldn't that create unexpected behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazarusA @Qfl3x