-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to fix Ti error #337
try to fix Ti error #337
Conversation
Thanks for this PR, could you please try to include a test example. For now, I approved CI to check if nothing breaks as it is. |
Thank you. After all tests passed, I will add new. |
Codecov ReportAll modified lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
@lazarusA, do you know about the It shows that 9 broken. But I can't found out which test failed. |
The test of Line 15 in 4f4f555
|
I'm doing another CI run. Let's see, I cannot do much today, only things from my phone. I could take a deeper look once I'm at my computer |
Thank you @lazarusA. |
Could you use https://juliadatacubes.github.io/YAXArrays.jl/dev/examples/generated/UserGuide/openNetCDF/ ? It's Ti still appearing when reading the files? |
I found both of |
try to fix #336, #330, #320, might also works for #301
This issue is related to
DD.dim2key(ti)
andDD.name(ti)
. They return different values.