Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would a PrettyTables for printing PR be welcomed? #81

Open
Moelf opened this issue Jul 10, 2021 · 2 comments
Open

Would a PrettyTables for printing PR be welcomed? #81

Moelf opened this issue Jul 10, 2021 · 2 comments

Comments

@Moelf
Copy link

Moelf commented Jul 10, 2021

image

image

@Moelf Moelf changed the title PrettyTables for printing welcomed? Would a PrettyTables for printing PR be welcomed? Jul 10, 2021
@Moelf
Copy link
Author

Moelf commented Jul 10, 2021

the main issue is type info such as Float32[ blah is too much. And that it's hard to customize just for my own TypaedTable.Table. Currently I have to do:

const _LazyTreeType = TypedTables.Table{<:NamedTuple, 1, NamedTuple{S, N}} where {S, N <: Tuple{Vararg{LazyBranch}}}

but it won't work if user materialized a table

@andyferris
Copy link
Member

Is the suggestion here to switch the printing logic to use PrettyTables.jl? I guess it's possible, but we need to be careful about dictionary-based tables too. Or we can steal the type-header logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants