Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamecols function for transform #2893

Closed
jtrakk opened this issue Oct 4, 2021 · 2 comments
Closed

renamecols function for transform #2893

jtrakk opened this issue Oct 4, 2021 · 2 comments
Labels
Milestone

Comments

@jtrakk
Copy link

jtrakk commented Oct 4, 2021

I would like to pass a renamecols function to transform. innerjoin takes a renamecols function and transform takes a renamecols::Bool. I want to replace the Bool with a function parameter that defaults to column_function(c) = "$(c)_function" and can be replaced with identity for users who currently pass renamecols=false.

@bkamins bkamins added the feature label Oct 4, 2021
@bkamins bkamins added this to the 1.x milestone Oct 4, 2021
@bkamins
Copy link
Member

bkamins commented Oct 4, 2021

This is a good proposal in line with some other proposals to allow dst to be a function in src => fun => dst, see #2876.
We will just need to work out the best approach.

@bkamins bkamins modified the milestones: 1.x, 1.3 Oct 4, 2021
@jtrakk
Copy link
Author

jtrakk commented Oct 4, 2021

Your proposal is better than mine. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants