Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support fence #16

Closed
maleadt opened this issue Nov 28, 2024 · 1 comment · Fixed by #19
Closed

Properly support fence #16

maleadt opened this issue Nov 28, 2024 · 1 comment · Fixed by #19

Comments

@maleadt
Copy link
Member

maleadt commented Nov 28, 2024

UnsafeAtomics.jl now relies on Base for fence:

UnsafeAtomics.jl/ext/UnsafeAtomicsLLVM/atomics.jl

Line 196 in 2eaec48

Core.Intrinsics.fence($(QuoteNode(order)))

That seems wrong, fence has been renamed to Threads.atomic_fence now (without an order argument): https://github.com/JuliaLang/julia/blob/447dc2d8e9a71669c6a3f62ff8ac71054c811a94/base/atomics.jl#L465-L468

We should probably add fence to the interface here, and add a proper implementation that supports arbitrary orderings and synchronization scopes.
@vchuravy vchuravy mentioned this issue Nov 30, 2024
Merged
@vchuravy
Copy link
Member

Fixed the first part, the second part is a bit more work :)

@vchuravy vchuravy mentioned this issue Nov 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement UnsafeAtomics.fence JuliaConcurrent/UnsafeAtomics.jl
2 participants
@vchuravy @maleadt