Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP 400 response in server side logs #71

Closed
Keno opened this issue Jan 9, 2018 · 9 comments
Closed

HTTP 400 response in server side logs #71

Keno opened this issue Jan 9, 2018 · 9 comments

Comments

@Keno
Copy link
Member

Keno commented Jan 9, 2018

[HTTP - 2018-01-09T12:36:09.11 ]: responding with response on connection i=3
HTTP.Response:

HTTP/1.1 400 Bad Request
Connection: keep-alive
Content-Length: 17

invalid signature

I don't think this was there with the old HttpServer code.
I believe @ararslan saw the same with nanosoldier at some point.

@KristofferC
Copy link
Contributor

I'm guessing JuliaWeb/GitHub.jl@42ef052 is not applied on the current GitHub.jl commit. Perhaps rebasing Github.jl on master would fix it.

@Keno
Copy link
Member Author

Keno commented Jan 9, 2018

It's in there. The error message is invalid signature rather than invalid event.

@Keno
Copy link
Member Author

Keno commented Jan 9, 2018

Seems like most requests are failing with this error message now.

@ararslan
Copy link

ararslan commented Jan 9, 2018

Yes, that's the same thing that's been happening with Nanosoldier.

@KristofferC
Copy link
Contributor

So are we doing something wrong in GitHub.jl or is HTTP.jl doing something wrong :/ Any ideas @quinnj?

@Keno
Copy link
Member Author

Keno commented Jan 9, 2018

I suspect we're not hashing the correct data anymore to compute the digest.

@ararslan
Copy link

Bump @quinnj. Any ideas?

@KristofferC
Copy link
Contributor

This is JuliaWeb/HTTP.jl#140

Most likely fixed by JuliaWeb/HTTP.jl#135.

@Keno
Copy link
Member Author

Keno commented Jan 27, 2018

This is fixed. However, after a few days, it stops responding to HTTP requests. No errors in the logs. I've bumped the HTTP.jl dependency and we'll see if that's any better.

@Keno Keno closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants