Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conj is a pun #66

Open
oxinabox opened this issue Oct 18, 2020 · 1 comment · May be fixed by #67
Open

conj is a pun #66

oxinabox opened this issue Oct 18, 2020 · 1 comment · May be fixed by #67

Comments

@oxinabox
Copy link
Member

conj(s::PersistentSet{T}, val) should not overload Base.conj.
Base.conj is complex conjugation.

I suggest replacing it with push.
We already provide push as an alias for conj.

push is a good name since push!(::Set, val) is how you add one element to a Base.Set
@shashi
Copy link
Contributor

shashi commented Oct 18, 2020

I agree

@rushabh-v rushabh-v linked a pull request Jan 11, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace conj with push and update tests rushabh-v/FunctionalCollections.jl
2 participants
@shashi @oxinabox