Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PersistentHashMap: get with default throws KeyError #61

Open
georgematheos opened this issue May 24, 2020 · 0 comments
Open

PersistentHashMap: get with default throws KeyError #61

georgematheos opened this issue May 24, 2020 · 0 comments

Comments

@georgematheos
Copy link
Contributor

georgematheos commented May 24, 2020

I've been getting some keyerrors when calling get(m, key, 0) where m::PersistentHashMap.

Based on a cursory look at the FunctionalCollections source code, it looks to me like the issue is arising because when checking whether there is a value for the key so it knows whether to return the default, the method get(::PersistentHashMap, key, default) instead checks whether there is a value for any key with the same hash as key. I don't think I understand the source code fully enough to be sure this is the problem, though.

(I'm referring to the following method, defined at PersistentHashMap.jl:149 on my install:)

function Base.get(m::PersistentHashMap, key, default)
    val = get(m.trie, reinterpret(Int, hash(key)), NotFound())
    (val === NotFound()) && return default
    val[key]
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant