Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setindex for assoc #27

Open
TotalVerb opened this issue Aug 2, 2016 · 1 comment
Open

Consider setindex for assoc #27

TotalVerb opened this issue Aug 2, 2016 · 1 comment

Comments

@TotalVerb
Copy link
Contributor

FixedSizeArrays uses setindex to mean what assoc does in this package. Personally, I find setindex more consistent. I don't have any opinion as to whether assoc should be kept or deprecated (note that setindex has opposite argument order).

Perhaps a new package can be spun off with definitions for non-mutating versions of Base functions, and packages like FunctionalCollections can extend those. In particular, it would be useful to make push, append, and the like extensible by other packages without requiring a dependency on FunctionalCollections. But that's a different issue.

@kmsquire
Copy link
Member

kmsquire commented Aug 2, 2016

Seems quite reasonable to me. This package doesn't receive much attention, so

  1. please feel free to submit a PR
  2. bump the PR if you don't get a quick response.

If you are interested in helping maintain/update the package, I suspect you could get commit access quite easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants