Proposal: Consider changing collection constructors to accept iterables

[kmsquire]

A recent change in Base does this (JuliaLang/julia#5897), so that, e.g., Set(1,2,3) is now Set([1,2,3]). This is mainly for efficiency--e.g., constructing from large collections no longer requires splatting:

a = rand(100000)
...
#s = Set(a...)   ## Old
s = Set(a)       ## New

[zachallaun]

I'm certainly open to this change. One of the ultimate goals of this package is to integrate with Base and be as familiar as possible. It's a way away from that, but sticking to the conventions present in Base is a big part of it.

[kmsquire]

Cool. I would love to see these in Base at some point.

[shashi]

@kmsquire could you check if this could be closed? Currently pset can handle any iterable. Please let me know if there are any other bits that could be moved closer to Base conventions.

[shashi]

The constructors for pset, phmap and pvec now accept iterables. This can be closed too.

[zachallaun]

Thanks for staying on top of this =)

[shashi]

I think it's worth moving this package to the JuliaLang org, if you are willing, so that it gets more visibility (people might need it but not know it yet. ;) ) and other collaborators can collectively work on features. @StefanKarpinski what do you think?

[zachallaun]

I'm definitely open to it if people would find it useful. I'm planning to do the same with FactCheck.jl. Most of my Julia projects are reasonably unmaintained at this point, which is a bummer.

[StefanKarpinski]

@zachallaun, you need admin rights here?

[zachallaun]

@StefanKarpinski Got it. Moving this repo and FactCheck.jl to julialang.

[StefanKarpinski]

Coolio. Thanks for doing that.

[zachallaun]

@StefanKarpinski All done, methinks. You can have your keys back now.

[StefanKarpinski]

Aight. Thanks again.

[shashi]

Sweet. Just tagged v0.1.1 JuliaLang/METADATA.jl#1656

Thanks! :)