Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release 0.18 #577

Closed
2 of 3 tasks
oxinabox opened this issue Feb 10, 2020 · 5 comments · Fixed by #643
Closed
2 of 3 tasks

Prepare for release 0.18 #577

oxinabox opened this issue Feb 10, 2020 · 5 comments · Fixed by #643

Comments

@oxinabox
Copy link
Member

oxinabox commented Feb 10, 2020

#578 requires release of a breaking version.

List of other things we want to do before releasing 0.18:

@oxinabox oxinabox changed the title Remove DisjointSets constructor taking splatted elements Prepare for release 0.18 Feb 10, 2020
@oxinabox
Copy link
Member Author

oxinabox commented Jun 3, 2020

#547 also requires a breaking release.

@davidanthoff
Copy link
Contributor

Is there some way for me to relatively figure out what was breaking in 0.18?

I got a bunch of CompatHelper notifications in my packages asking whether I want to add 0.18 to the list of compatible packages. So now I go to this repo here, and see a CHANGELOG, hurray, that should help me make that decision. Ok, the CHANELOG directs me to the releases. I look there, and I see a bunch of releases and PRs merged etc., but it is really not clear from that why this was a breaking release, what I need to be aware of in making the update decision.

I could see two good general solutions for this: a) either add [BREAKING] to those PRs and issues that are breaking, that would make it relatively easy to look at the auto-generated release notes for releases and figure out what I need to look at, or b) just write a very short release not for breaking releases that tell people that get the CompatHelper notification what actually broke.

@oxinabox
Copy link
Member Author

oxinabox commented Sep 2, 2020

Yeah,we could do that better.

The breaking changes are:

  • removal of things that were deprecated like top
  • Heap type parameters and constructors.

@davidanthoff
Copy link
Contributor

Thanks!

I think this is actually a general problem across the ecosystem, but I don't really have a very good idea how to solve it... Maybe TagBot could open an issue whenever a breaking release is tagged that is called "Update release notes with information what was breaking" or something like that...

@oxinabox
Copy link
Member Author

oxinabox commented Sep 2, 2020

I think moving forward I will at least attach a breaking label to each PR.
and maybe rename them

Maybe tagbot coult be patched to check for and include breaking labels so i didn;t have to rename it myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants