You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
function s3_xxx_xxx(::AbstractAWSConfig, a, b, c; kw1="foo", kw2="bar")
# function body
end
s3_xxx_xxx(a...; b...) = s3_xxx_xxx(global_aws_config(), a...; b...)
Whereas AWS.jl now passes the AbstractAWSConfig as a keyword argument.
Reverse this, so that the AbstractAWSConfig is not in the main version of each function, but only in the keyword version of each function.
Here is the new form:
function s3_xxx_xxx(a, b, c; aws_config::AbstractAWSConfig=global_aws_config(), kw1="foo", kw2="bar")
# function body
end
s3_xxx_xxx(aws_config::AbstractAWSConfig, a...; b...) = s3_xxx_xxx(a...; aws_config=aws_config, b...)
This in general is more consistent with AWS.jl and should remain backward compatible with existing uses of AWSS3
Most function arguments are of the form
Whereas
AWS.jl
now passes theAbstractAWSConfig
as a keyword argument.Reverse this, so that the
AbstractAWSConfig
is not in the main version of each function, but only in the keyword version of each function.Here is the new form:
This in general is more consistent with
AWS.jl
and should remain backward compatible with existing uses ofAWSS3
Here is an example in AWS.jl.
https://github.com/JuliaCloud/AWS.jl/blob/master/src/services/sts.jl#L711
The text was updated successfully, but these errors were encountered: