From 3ae57206145dd0094847082204dc3392fe302d5d Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Fri, 18 Oct 2024 13:17:59 +0200 Subject: [PATCH] rm stale notes (#694) --- src/utilities/downloads_backend.jl | 3 +-- src/utilities/request.jl | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/utilities/downloads_backend.jl b/src/utilities/downloads_backend.jl index 388284b2e7..4e3133b0c4 100644 --- a/src/utilities/downloads_backend.jl +++ b/src/utilities/downloads_backend.jl @@ -11,8 +11,7 @@ It has one field, which is the `Downloads.Downloader` to use. If set to `nothing`, the default, then a global downloader object will be used. -Downloads.jl tends to perform better under concurrent operation than HTTP.jl, -particularly with `@async` / `asyncmap`. Note that threading (e.g. `@spawn` or `@threads`) with Downloads.jl is broken on Julia releases prior to 1.8 (https://github.com/JuliaLang/Downloads.jl/issues/182#issuecomment-1069269944). +Note that threading (e.g. `@spawn` or `@threads`) with Downloads.jl is broken on Julia releases prior to 1.8 (https://github.com/JuliaLang/Downloads.jl/issues/182#issuecomment-1069269944). """ struct DownloadsBackend <: AWS.AbstractBackend downloader::Union{Nothing,Downloads.Downloader} diff --git a/src/utilities/request.jl b/src/utilities/request.jl index e083017e67..dfe2ce3205 100644 --- a/src/utilities/request.jl +++ b/src/utilities/request.jl @@ -19,10 +19,7 @@ which defaults to an empty dictionary. This field provides default options to use, which can be any of the keyword arguments to [`HTTP.request`](https://juliaweb.github.io/HTTP.jl/stable/public_interface/#HTTP.request). These options are overwritten by any per-request options. -This is the default backend, and the only option until AWS.jl v1.57.0. Therefore, it has -been used more often in practice, and may be more mature. Note, however, HTTP.jl currently -(March 2022) has issues with concurrency (see [HTTP.jl#517](https://github.com/JuliaWeb/HTTP.jl/issues/517)). Therefore, it may be advisable to switch to the [`DownloadsBackend`](@ref) if you -are using concurrency. +This is the default backend. """ struct HTTPBackend <: AbstractBackend http_options::AbstractDict{Symbol,<:Any}